Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Giphy tracks #264

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Remove Giphy tracks #264

merged 2 commits into from
Jun 11, 2020
+1 −6

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Jun 11, 2020 •
edited
Loading

Ref: wordpress-mobile/WordPress-iOS#13803
Can be tested with WPiOS PR: wordpress-mobile/WordPress-iOS#14302

This removes Giphy tracks as Giphy is no longer being used.

@ScoutHarris ScoutHarris self-assigned this Jun 11, 2020
@ScoutHarris ScoutHarris mentioned this pull request Jun 11, 2020
Merged
3 tasks
@ScoutHarris ScoutHarris requested review from frosty and Gio2018 June 11, 2020 21:17
@ScoutHarris ScoutHarris marked this pull request as ready for review June 11, 2020 21:17
Gio2018
Gio2018 approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@Gio2018 Gio2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I just had one question.

WordPressShared/Core/Analytics/WPAnalytics.h
@@ -74,7 +74,6 @@ typedef NS_ENUM(NSUInteger, WPAnalyticsStat) {
WPAnalyticsStatEditorAddedPhotoViaWPMediaLibrary,
WPAnalyticsStatEditorAddedVideoViaWPMediaLibrary,
WPAnalyticsStatEditorAddedOtherMediaViaWPMediaLibrary,
WPAnalyticsStatEditorAddedPhotoViaGiphy,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the related Tenor tracks be added in a separate PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. The Tenor tracks are using the new system that doesn't require Shared. And have already been added to WP.

@ScoutHarris ScoutHarris merged commit 43619bf into develop Jun 11, 2020
@ScoutHarris ScoutHarris deleted the issue/remove_giphy_tracks branch June 11, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gio2018 Gio2018 Gio2018 approved these changes

@frosty frosty Awaiting requested review from frosty

Assignees

@ScoutHarris ScoutHarris

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScoutHarris @Gio2018